Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Fix eslint formatting in scripts #19765

Merged
merged 1 commit into from
Nov 7, 2022
Merged

Build: Fix eslint formatting in scripts #19765

merged 1 commit into from
Nov 7, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Nov 7, 2022

Issue: Code formatting wasn't working in the scripts directory.

What I did

Fix as suggested by @IanVS

@tmeasday tmeasday requested a review from IanVS November 7, 2022 06:21
@tmeasday tmeasday added the build Internal-facing build tooling & test updates label Nov 7, 2022
@tmeasday tmeasday changed the title Fix eslint formatting in scripts Build: Fix eslint formatting in scripts Nov 7, 2022
shilman
shilman approved these changes Nov 7, 2022
View reviewed changes
Copy link
Member

@shilman shilman left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@shilman shilman merged commit c47ea63 into next Nov 7, 2022
@shilman shilman deleted the fix-eslint-in-scripts branch November 7, 2022 07:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@IanVS IanVS Awaiting requested review from IanVS

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmeasday @shilman