Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Fix benchmark to run on local packages #19832

Merged
merged 6 commits into from
Nov 15, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Nov 14, 2022

Issue: N/A

What I did

Alternative to #19797 to make sure bench runs against local package versions by reusing sandbox logic for configuring yarn2. This version benchmarks a clean project version so that the benchmarks don't change as we add more stories/addons to the sandboxes.

  • Extend sandbox to be able to target a different root directory
  • Add --skip-template-stories to sandbox
  • Update bench CI config

How to test

  • CI passes

@shilman shilman added the build Internal-facing build tooling & test updates label Nov 14, 2022
@shilman shilman changed the title Task: Add ability to skip stories/addons Build: Fix benchmark to run on local packages Nov 14, 2022
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I see, it makes sense to use a consistent, unchanging set of stories for the benches. WFM.

@shilman shilman merged commit 9321b65 into next Nov 15, 2022
@shilman shilman deleted the shilman/add-skip-stories-to-bench branch November 15, 2022 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants