Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Increase max node memory for jobs #19856

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Build: Increase max node memory for jobs #19856

merged 2 commits into from
Nov 16, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Nov 16, 2022

Issue:

What I did

Increased the memory available to node in circle CI, trying to get the chromatic build to pass in CI.

How to test

CI

@IanVS IanVS added the build Internal-facing build tooling & test updates label Nov 16, 2022
@IanVS IanVS requested review from yannbf and shilman November 16, 2022 17:24
@@ -405,6 +405,8 @@ jobs:
executor:
class: medium+
name: sb_node_16_browsers
environment:
NODE_OPTIONS: --max_old_space_size=6144
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know if this helped, but it failed once without and succeeded twice with it. Might just be coincidence?

@yannbf
Copy link
Member

yannbf commented Nov 16, 2022

Thanks Ian! Merging cc @ndelangen

@yannbf yannbf merged commit 834e11b into next Nov 16, 2022
@yannbf yannbf deleted the failing-vite-build branch November 16, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants