Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Types: Rationalize story-based types and de-prefix #19919

Merged
merged 23 commits into from
Nov 28, 2022
Merged

Types: Rationalize story-based types and de-prefix #19919

merged 23 commits into from
Nov 28, 2022

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Nov 22, 2022 •
edited
Loading

Issue: N/A

What I did

  • Created types files for various core "concepts" / modules:
    • index
    • csf files
    • stories
    • composed stories
    • channel api
  • Deleted redundant/unused types and combined duplicate ones
    • In some cases this led to small, trivial code changes.
  • Removed prefixes from all the types above, and updated inline

What I didn't do (in this PR)

  • Resolve addons types and re-export (I think we may want to do some of this).
  • Resolve remaining api story types
    • There is some naming overlap with "entry" here, I think maybe we should pick a different name for members of the stories hash, any ideas @ndelangen?
    • Also we probably need to re-export some of these for addons

@tmeasday tmeasday added maintenance User-facing maintenance tasks typescript labels Nov 22, 2022
@tmeasday tmeasday requested a review from ndelangen November 22, 2022 07:13
tmeasday added a commit that referenced this pull request Nov 24, 2022
@tmeasday
Remove non-type conformant summary code
35b82d6 
See conversation here: #19919 (comment)
@tmeasday tmeasday requested a review from ndelangen November 24, 2022 03:40
@tmeasday tmeasday force-pushed the tom/sb-878-cleanup-de-duplicate-storybooktypes branch from 44e2948 to e066923 Compare November 25, 2022 04:46
@tmeasday tmeasday merged commit fd1db96 into next Nov 28, 2022
@tmeasday tmeasday deleted the tom/sb-878-cleanup-de-duplicate-storybooktypes branch November 28, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannyhw dannyhw dannyhw left review comments

@yannbf yannbf yannbf left review comments

@ndelangen ndelangen ndelangen approved these changes

Assignees
No one assigned
Labels
maintenance User-facing maintenance tasks typescript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tmeasday @yannbf @ndelangen @dannyhw