-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix "__webpack_require__.nmd is not a function issue" in Angular 15 #19937
Merged
valentinpalkovic
merged 6 commits into
next
from
valentin/fix-angular-15-incompatibility
Nov 24, 2022
Merged
Fix "__webpack_require__.nmd is not a function issue" in Angular 15 #19937
valentinpalkovic
merged 6 commits into
next
from
valentin/fix-angular-15-incompatibility
Nov 24, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
added
bug
angular
ci:merged
Run the CI jobs that normally run when merged.
labels
Nov 23, 2022
valentinpalkovic
force-pushed
the
valentin/fix-angular-15-incompatibility
branch
from
November 23, 2022 12:10
fb3e88b
to
b654726
Compare
valentinpalkovic
changed the title
Valentin/fix angular 15 incompatibility
Fix Angular 15 incompatibility
Nov 23, 2022
3 tasks
valentinpalkovic
changed the title
Support Angular 15
Fix "__webpack_require__ is not a function issue" in Angular 15
Nov 23, 2022
valentinpalkovic
changed the title
Fix "__webpack_require__ is not a function issue" in Angular 15
Fix "__webpack_require__.nmd is not a function issue" in Angular 15
Nov 23, 2022
valentinpalkovic
force-pushed
the
valentin/fix-angular-15-incompatibility
branch
from
November 23, 2022 13:06
07f5518
to
f69d517
Compare
valentinpalkovic
force-pushed
the
valentin/fix-angular-15-incompatibility
branch
from
November 23, 2022 13:07
f69d517
to
e20eb29
Compare
ndelangen
reviewed
Nov 23, 2022
ndelangen
reviewed
Nov 23, 2022
code/frameworks/angular/src/server/plugins/normalize-angular-entry-plugin.js
Outdated
Show resolved
Hide resolved
ndelangen
reviewed
Nov 23, 2022
code/frameworks/angular/src/server/plugins/normalize-angular-entry-plugin.js
Outdated
Show resolved
Hide resolved
ndelangen
approved these changes
Nov 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19878
What I did
Fix "webpack_require.nmd is not a function" issue introduced with Angular 15
How to test
If your answer is yes to any of these, please make sure to include it in your PR.