Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tech: rename api to manager-api #19944

Merged
merged 8 commits into from
Nov 24, 2022
Merged

Tech: rename api to manager-api #19944

merged 8 commits into from
Nov 24, 2022

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Nov 23, 2022

Based on: #19749

What I did

I renamed lib/api to lib/manager-api, and renamed the package to match.
I created a shim package to keep backwards compatibility.

@ndelangen ndelangen self-assigned this Nov 23, 2022
@ndelangen ndelangen added the maintenance User-facing maintenance tasks label Nov 23, 2022
@ndelangen ndelangen changed the title rename api to manager-api Tech: rename api to manager-api Nov 23, 2022
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from one little thing

code/lib/manager-api-shim/README.md Outdated Show resolved Hide resolved
Base automatically changed from tech/introduce-preview-api to next November 24, 2022 13:04
@ndelangen ndelangen merged commit 65a52da into next Nov 24, 2022
@ndelangen ndelangen deleted the tech/rename-api branch November 24, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance User-facing maintenance tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants