Addon-interactions: Fix duplicated elements in the panel #20004
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
reviewed
Nov 29, 2022
ndelangen
approved these changes
Nov 29, 2022
3 tasks
thafryer
reviewed
Nov 29, 2022
tmeasday
approved these changes
Nov 30, 2022
I'll take a look at it now, from the looks of CI it seems that it only affects a few projects, so probably a bug in the clearing of the form in those frameworks |
yannbf
force-pushed
the
feat/fix-interactions-addon
branch
3 times, most recently
from
8a9fd15 to
9897e45
Compare
even though it seems like it's not fixing, it's actually breaking it
yannbf
force-pushed
the
feat/fix-interactions-addon
branch
from
9897e45 to
084546b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #19969
What I did
This PR fixes a logic that was broken in alpha 48 and adds E2E tests so we avoid getting into that situation again
How to test
If your answer is yes to any of these, please make sure to include it in your PR.