Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support next/image component in Next.js 12/13 properly #20028

Merged
merged 2 commits into from
Dec 1, 2022
Merged

Support next/image component in Next.js 12/13 properly #20028

merged 2 commits into from
Dec 1, 2022

Conversation

valentinpalkovic
Copy link
Contributor

@valentinpalkovic valentinpalkovic commented Nov 30, 2022 •
edited
Loading

Issue: #17950

What I did

I have improved how the next/image component is used in the Storybook context. Furthermore, I have enhanced the next/future/image support for Next.js v12 and next/legacy/image support for Next.js v13.

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@valentinpalkovic valentinpalkovic marked this pull request as ready for review November 30, 2022 13:29
@valentinpalkovic valentinpalkovic force-pushed the valentin/support-image-component-in-nextjs-13 branch 3 times, most recently from d6f4b43 to 2d30461 Compare December 1, 2022 07:36
@valentinpalkovic valentinpalkovic force-pushed the valentin/support-image-component-in-nextjs-13 branch from 2d30461 to a501a5d Compare December 1, 2022 12:12
@yannbf yannbf added the nextjs label Dec 1, 2022
kylegach
kylegach approved these changes Dec 1, 2022
View reviewed changes
Copy link
Contributor

@kylegach kylegach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't run it locally, but this seems sound to me. I particularly like the IgnorePlugin approach!

@valentinpalkovic valentinpalkovic merged commit 226b032 into next Dec 1, 2022
@valentinpalkovic valentinpalkovic deleted the valentin/support-image-component-in-nextjs-13 branch December 1, 2022 22:04
@shilman shilman mentioned this pull request Dec 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

@kylegach kylegach kylegach approved these changes

Assignees
No one assigned
Labels
bug nextjs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@valentinpalkovic @kylegach @yannbf