CLI: Add upgrade telemetry details #20064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valentinpalkovic
approved these changes
Dec 2, 2022
tmeasday
approved these changes
Dec 2, 2022
Comment on lines
+31
to
+37
| // Note that this probably doesn't work in PNPM mode | ||
| export const getStorybookCoreVersion = async () => { | ||
| const coreVersions = await Promise.all( | ||
| ['@storybook/core-common', '@storybook/core-server'].map(getActualPackageVersion) | ||
| ); | ||
| return coreVersions.find((v) => v.version)?.version; | ||
| }; |
There was a problem hiding this comment.
Can we reuse the code we use to check all SB versions are in sync for this (i.e. check all direct dependencies that are from the monorepo) rather than just trying a couple of packages that won't work in pnpm?
There was a problem hiding this comment.
That code needs a lot of work. I'll leave this for now, but we should definitely invest in making this area more robust.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
What I did
Add extra metadata to the
upgradeevent:How to test
In the project of your choice, where
sbis the locally-built version: