Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: replace image placeholder url in example stories for nextjs #20069

Merged
merged 1 commit into from
Dec 2, 2022
Merged

Build: replace image placeholder url in example stories for nextjs #20069

merged 1 commit into from
Dec 2, 2022

Conversation

valentinpalkovic
Copy link
Contributor

Issue: N/A

What I did

Fix flaky placeholder images

How to test

  • Is this testable with Jest or Chromatic screenshots?

@yannbf yannbf added build Internal-facing build tooling & test updates and removed bug labels Dec 2, 2022
@yannbf yannbf changed the title Fix flaky placeholder Build: replace image placeholder url in example stories for nextjs Dec 2, 2022
yannbf
yannbf approved these changes Dec 2, 2022
View reviewed changes
Copy link
Member

@yannbf yannbf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@valentinpalkovic valentinpalkovic merged commit 2e10672 into next Dec 2, 2022
@valentinpalkovic valentinpalkovic deleted the valentin/fix-flaky-placeholder branch December 2, 2022 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees
No one assigned
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@valentinpalkovic @yannbf