Fix peer dependencies for npm8/pnpm/yarn pnp - retry #20110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
added
maintenance
Co-authored-by: Yann Braga <yannbf@gmail.com>
|
@shilman self merging!!! |
|
I think this closes #19821, right? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #17448
Replaced: #20017
What I did
Added
reactand@mdx-js/reactshims toaddon-docsas partial solution to npm8/pnpm peer dependency issues.Currently this is failing due to React version mismatches between
@storybook/addon-docsand@storybook/blockswhich uses the user's React version as a peer dependency.Cc @ndelangen @IanVS @tmeasday
How to test
CI should pass, but honestly that's not enough in this case.
We need to release this in a alpha, and test it using