Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up babelModeV7 migration and code #20117

Merged
merged 1 commit into from
Dec 7, 2022
Merged

Clean up babelModeV7 migration and code #20117

merged 1 commit into from
Dec 7, 2022

Conversation

shilman
Copy link
Member

@shilman shilman commented Dec 7, 2022 •
edited
Loading

Issue: N/A

What I did

  • Instructions were out of date
  • Removed lingering config code

Did not update docs since there are a bunch of feature flags that need updated docs @jonniebigodes

Self-merging @tmeasday

How to test

  • CI passes

@shilman shilman added maintenance User-facing maintenance tasks configuration babel / webpack labels Dec 7, 2022
tmeasday
tmeasday reviewed Dec 7, 2022
View reviewed changes
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shilman shilman merged commit dd72a50 into next Dec 7, 2022
@shilman shilman deleted the shilman/clean-babel-mode-v7 branch December 7, 2022 04:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmeasday tmeasday tmeasday approved these changes

Assignees
No one assigned
Labels
configuration babel / webpack maintenance User-facing maintenance tasks
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shilman @tmeasday