Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-enable TS 4.9 CLI templates #20159

Merged
merged 1 commit into from
Dec 12, 2022

Conversation

kasperpeulen
Copy link
Contributor

Re enabling TS 4.9 CLI templates, now CSF-tools and the eslint plugin are updated.

@kasperpeulen kasperpeulen requested a review from shilman December 8, 2022 13:14
@kasperpeulen kasperpeulen added ci:daily Run the CI jobs that normally run in the daily job. feature request ci:pr and removed ci:daily Run the CI jobs that normally run in the daily job. ci:pr labels Dec 8, 2022
@kasperpeulen kasperpeulen force-pushed the kasper/sb-1047-re-enable-ts-49-ci-templates branch from 980d78f to 75c9a26 Compare December 12, 2022 10:02
@kasperpeulen kasperpeulen requested a review from yannbf December 12, 2022 11:31
@@ -170,10 +170,13 @@ export function detectLanguage(packageJson?: PackageJson) {
(!hasDependency(packageJson, '@typescript-eslint/parser') ||
hasDependency(packageJson, '@typescript-eslint/parser', (version) =>
semver.gte(semver.coerce(version), '5.44.0')
)) &&
(!hasDependency(packageJson, 'eslint-plugin-storybook') ||
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!!

@kasperpeulen kasperpeulen merged commit 589dcfc into next Dec 12, 2022
@kasperpeulen kasperpeulen deleted the kasper/sb-1047-re-enable-ts-49-ci-templates branch December 12, 2022 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants