Svelte-vite: remove svelteOptions in automigration
#20270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shilman
changed the title
svelteOptions in automigrationsvelteOptions in automigration
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #20236
This PR makes the
newFrameworksandsveltekitFrameworkautomigrations remove thesvelteOptionsproperty in main.js, as it will break in 7.0 and will likely not be supported.This implements Proposal A in #20236, see that issue for more context.
I won't change anything in MIGRATIONS.md until we've made a final decision about supporting it or not.
I tested this by upgrading a 6.5 project with SvelteKit, Svelte-Vite without svelteOptions and Svelte-Vite with svelteOptions.