Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

React-vite: Pin react-docgen version #20300

Merged
merged 1 commit into from
Dec 16, 2022
Merged

React-vite: Pin react-docgen version #20300

merged 1 commit into from
Dec 16, 2022

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Dec 16, 2022

Issue:

The latest version of react-docgen went to ESM only (dang it) and screwed things up for us.

What I did

This pins to a version we know is working. I tried to prebundle it in #20299, but that's hitting some other error. We can try to figure out how to use the latest version later, after we unblock CI.

How to test

CI is failing, hopefully this makes it pass.

@IanVS
Copy link
Member Author

IanVS commented Dec 16, 2022

This is ready for mergin', @shilman.

@shilman shilman merged commit f33ff58 into next Dec 16, 2022
@shilman shilman deleted the pin-react-docgen branch December 16, 2022 06:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants