CLI: write into a log file if automigrations fail #20310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yannbf
force-pushed
the
feat/automigration-log-file
branch
from
d583987
to
54c12bd
Compare
ndelangen
approved these changes
Dec 19, 2022
- the errors will get supressed in normal output but shown in the log file
yannbf
force-pushed
the
feat/automigration-log-file
branch
from
6b5bbb8
to
f4388e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
The automigration command now will suppress errors from the logs, while writing the entire output to a
migration-storybook.log(to followbuild-storybook.logconvention) file. The log file will only be provided to the user if there are failures, and it will contain all the errors in full.Here's a comparison logfile <-> command line:
How to test
If your answer is yes to any of these, please make sure to include it in your PR.