Vite: Include user config optimizeDeps
in final optimizeDeps
#20313
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
What I did
currently: If a dev specifies
optimizeDeps
in their custom vite config, it will be ignored by@storybook/build-vite
. I would consider this a bug, because a custom config should still be supported where possiblenow: I spread
optimizeDeps
into the final object so it will update the config as expectedjust for demonstration (my weird use case): here I create a custom vite config where
optimizeDeps.esbuildOptions
forces .js files to be read as .jsxwith this PR it will be included in the final config:
How to test
If your answer is yes to any of these, please make sure to include it in your PR.