Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: Remove the non-cross-platform dash-S option #20360

Merged
merged 1 commit into from
Dec 21, 2022
Merged

Build: Remove the non-cross-platform dash-S option #20360

merged 1 commit into from
Dec 21, 2022

Conversation

ndelangen
Copy link
Member

Issue: build failures on windows

What I did

Remove a CLI flag that doesn't work on windows

@ndelangen ndelangen self-assigned this Dec 21, 2022
@ndelangen ndelangen added the build Internal-facing build tooling & test updates label Dec 21, 2022
@ndelangen
Copy link
Member Author

@shilman self merging

@ndelangen ndelangen merged commit c2f424f into next Dec 21, 2022
@ndelangen ndelangen deleted the tech/no-dash-S branch December 21, 2022 08:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@ndelangen ndelangen

Labels
build Internal-facing build tooling & test updates
Projects
Core Team Projects
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ndelangen