-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: fix deprecated ReactDOM.findDOMNode calls #20368
Conversation
@thebuilder have you testing this locally? I'm looking at this PR's deployed storybook here: And I see the warnings in the console... 😢 |
Seems like another instance of |
Had a look - There was actually two instances of |
Looks good! No errors on Chromatic now. https://635781f3500dd2c49e189caf-pxjngorqfm.chromatic.com/?path=/story/storybook-blocks-blocks-anchor--default Is there an issue for the warning about
|
That's fine. it's kinda expected.. Thanks for this awesome work! |
Is the failing checks expected? Missing playwright executable for some reason 🤔
|
Merging in the Be aware we're currently having CI issues because babel/babel#15301 has yet to be released. |
@thebuilder, this is looking amazing. Thanks so much for the contribution. If you're ok with it, can you message me on our Discord Server (same username) as I wanted to go over with you a small item related to this pull request? Looking forward to hearing from you. Have a fantastic day Stay safe |
Issue: #20140
What I did
ReactResizeDector
to useuseResizeDetector
. This ensuresfindDOMNode()
is not called, since the hook returns aref
that's passed to the monitored element.nodeRef
to<Draggable>
in UI Container, to prevent it from callingfindDOMNode()
The
code/addons/jest/src/components/Panel.tsx
had to be refactored, since it creates aContent
element that, then creates an internalmap
to render out all the Test panels. This prevented nested hooks/refs from being used, so moved the code into aTestPanel
component.Unsure if we should just get rid of
Content
entirely, since it seems to only exist to applyflex
on a wrapping<div>
.