-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vue3: Add TS / legacy TS CLI templates #20434
Conversation
…to vue-vite-default-ts
…to vue-vite-default-ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! I'm not a vue user so I'll let others chime in on that part of things. But I did notice that you're using the satisfies
syntax that is only supported in TS 4.9+. Users with older versions of TypeScript will still get the JavaScript assets (after #20458 is merged, at least). Would you like to also create a ts-legacy
version of these assets, that doesn't use satisfies
?
…to vue-vite-default-ts
…to vue-vite-default-ts
it is already done @IanVS 👍 It is late for you now since you are in Michigan, nobody is here to approve my PR 😔 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, thanks @chakAs3.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job @chakAs3 and happy new year!
Issue:
What I did
I have added typescript template for Vue Renderer cli . as when you install via npx on vue3-vite it installs js files with old usage of deprecated stuff, I avoided all deprecation to have a clean typescript template, It will help also maintainers by using generated sandbox repo with typescript
How to test
If your answer is yes to any of these, please make sure to include it in your PR.