Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vue3: Add TS / legacy TS CLI templates #20434

Merged
merged 21 commits into from
Jan 1, 2023

Conversation

chakAs3
Copy link
Contributor

@chakAs3 chakAs3 commented Dec 29, 2022

Issue:

What I did

I have added typescript template for Vue Renderer cli . as when you install via npx on vue3-vite it installs js files with old usage of deprecated stuff, I avoided all deprecation to have a clean typescript template, It will help also maintainers by using generated sandbox repo with typescript

How to test

  • Is this testable with Jest or Chromatic screenshots? I guess
  • Does this need a new example in the kitchen sink apps? no need
  • Does this need an update to the documentation? no

If your answer is yes to any of these, please make sure to include it in your PR.

@shilman shilman requested a review from kasperpeulen December 29, 2022 22:43
@IanVS IanVS added maintenance User-facing maintenance tasks vue3 labels Dec 30, 2022
Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I'm not a vue user so I'll let others chime in on that part of things. But I did notice that you're using the satisfies syntax that is only supported in TS 4.9+. Users with older versions of TypeScript will still get the JavaScript assets (after #20458 is merged, at least). Would you like to also create a ts-legacy version of these assets, that doesn't use satisfies?

code/e2e-tests/addon-interactions.spec.ts Outdated Show resolved Hide resolved
@chakAs3 chakAs3 requested review from IanVS and removed request for kasperpeulen December 31, 2022 01:29
@chakAs3
Copy link
Contributor Author

chakAs3 commented Dec 31, 2022

Thanks for this! I'm not a vue user so I'll let others chime in on that part of things. But I did notice that you're using the satisfies syntax that is only supported in TS 4.9+. Users with older versions of TypeScript will still get the JavaScript assets (after #20458 is merged, at least). Would you like to also create a ts-legacy version of these assets, that doesn't use satisfies?

it is already done @IanVS 👍 It is late for you now since you are in Michigan, nobody is here to approve my PR 😔

Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @chakAs3.

@shilman shilman added the cli label Jan 1, 2023
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job @chakAs3 and happy new year!

@shilman shilman changed the title Vue vite default ts Vue3: Add TS / legacy TS CLI templates Jan 1, 2023
@shilman shilman merged commit 9816dc6 into storybookjs:next Jan 1, 2023
@chakAs3
Copy link
Contributor Author

chakAs3 commented Jan 2, 2023

Great job @chakAs3 and happy new year!

Thanks @shilman Happy new year from Dubai I hope it will be an amazing year for Everyone,and Storybook will rock

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli maintenance User-facing maintenance tasks vue3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants