Build: remove unneeded dependencies & upgrades #20533
Conversation
ndelangen
changed the title
Build: remove usage of enzyme
…ook into norbert/cleanup-babel
| @@ -279,44 +237,28 @@ | |||
| "jest-os-detection": "^1.3.1", | |||
| "jest-serializer-html": "^7.1.0", | |||
| "jest-watch-typeahead": "^2.2.1", | |||
| "lerna": "^3.22.1", | |||
| "lerna": "^6.4.0", | |||
There was a problem hiding this comment.
@shilman ☝️ is this OK?
There was a problem hiding this comment.
Nice! I love me some good dependency cleanups.
I have been meaning to ask, when do we need to add dependencies to the top-level package.json, and when do we not? It seems like much of the cleanup you're doing is removing packages there. I thought yarn monorepos should handle hoisting up packages to the top level automatically, so I would guess that only dev tools that need to run at the top level need to be included, but it seems like there's much more. Is that so that yarn task can work properly, or something?
code/renderers/web-components/src/docs/web-components-properties.test.ts
Show resolved
Hide resolved
|
@IanVS regarding where dependencies should be located. I'd like to have all devDependencies that are unique in the packages' devDependencies. I'd like to optimize a bit for future splitting the monorepo apart more. I think code/package.json should have 0 dependencies, except for maybe internal ones, that's a long term goal. Very open to discussing if that's a good goal and on how to achieve it if it indeed is.! |
|
@shilman I'm going to hold off merging this, until you've given an 👌 sign, about the lerna upgrade. |
…ook into norbert/cleanup-babel
What I did