Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vue3: rendering slots if are set and passed from controls #20536

Merged
merged 4 commits into from
Jan 11, 2023

Conversation

chakAs3
Copy link
Contributor

@chakAs3 chakAs3 commented Jan 8, 2023

Issue:

What I did

currently, the slots are not rendered even though they are detected in the controls and set which is unexpected behaviour
So I added code to be rendered if the component has slots and the user passe slot value via the controls

How to test

using the vue3-vite/default-ts. add slots to the Button.vue
image

the slots will be detected on the control so you can set these values to see them rendered on the component
image

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@ndelangen ndelangen merged commit cfa1644 into storybookjs:next Jan 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants