Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade babel-loader to ^9.0.0 #20577

Merged
merged 4 commits into from
Jan 16, 2023

Conversation

SebastianKapunkt
Copy link
Contributor

Issue: In our project, we would like to update babel loader to 9.0.0 and above. Currently, the @storybook/vue package from storybook is blocking this update.

Babel 9.0.0 release: https://github.com/babel/babel-loader/releases/tag/v9.0.0

What I did

Added babel loader 9.0.0 to peer dependencies to @storybook/vue

How to test

  • Is this testable with Jest or Chromatic screenshots?
  • Does this need a new example in the kitchen sink apps?
  • Does this need an update to the documentation?

If your answer is yes to any of these, please make sure to include it in your PR.

@ndelangen ndelangen self-requested a review January 14, 2023 00:31
@ndelangen ndelangen changed the title Upgrade babel-loader to ^9.0.0 for /vue Upgrade babel-loader to ^9.0.0 Jan 16, 2023
@SebastianKapunkt
Copy link
Contributor Author

@ndelangen thanks for the additional effort!

@ndelangen ndelangen merged commit d3c3de0 into storybookjs:next Jan 16, 2023
@SebastianKapunkt SebastianKapunkt deleted the upgrade-babel-loader branch January 16, 2023 10:20
@amureki
Copy link

amureki commented Jan 17, 2023

@ndelangen thank you for finishing and merging this one!
I see that it was added to 7.0.0 beta release. 🚀

Is it also possible to add to 6.15.6 release? Is it planned? 🙏

@ndelangen
Copy link
Member

No that's not planned @amureki

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants