Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Fix core preset default value #20646

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Jan 17, 2023

Issue: N/A

What I did

In a few places in core-server, object destructuring is used, however with undefined as fallback value.
That crashed Storybooks in different scenarios, so this PR fixes that case.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@shilman shilman changed the title Core: use proper defaults when calling core preset Core: Fix default when calling core preset Jan 18, 2023
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@shilman shilman changed the title Core: Fix default when calling core preset Core: Fix core preset default value Jan 18, 2023
@shilman shilman merged commit 26dac37 into next Jan 18, 2023
@shilman shilman deleted the fix/safe-check-in-core-preset branch January 18, 2023 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants