Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Svelte: Remove babel/core peer dep #20650

Merged
merged 1 commit into from
Jan 17, 2023
Merged

Svelte: Remove babel/core peer dep #20650

merged 1 commit into from
Jan 17, 2023

Conversation

IanVS
Copy link
Member

@IanVS IanVS commented Jan 17, 2023

Issue: N/A

image

https://discord.com/channels/486522875931656193/495147526278610945/1064676166092476566

What I did

I have removed babel/core from peerDependencies, as it is no longer used at all in this package.

How to test

CI should be sufficient. After the release, we can install storybook in a svelte project with pnpm and verify no dep warnings.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Contributor

@benmccann benmccann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@IanVS IanVS merged commit ee3c42f into next Jan 17, 2023
@IanVS IanVS deleted the svelte/remove-babel-dep branch January 17, 2023 14:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants