-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Angular Providers in boostrapApplication option #20746
Use Angular Providers in boostrapApplication option #20746
Conversation
@valentinpalkovic I updated the mechanism to not cache the componentNgModule while better process the imports and providers separately |
Now, this kind of error is back:
As I told you yesterday, this error is pretty strange because although Standalone components are used and bootstrapped independently from each other, they still somehow infer. Take for example a look at http://localhost:6006/?path=/docs/example-button--docs. Only the first button on the top is rendered. All the other Stories at the bottom aren't. That was the reason why I have introduced that ngModule kind of caching to resolve this issue. |
code/frameworks/angular/src/client/angular-beta/utils/PropertyExtractor.ts
Outdated
Show resolved
Hide resolved
code/frameworks/angular/src/client/angular-beta/utils/PropertyExtractor.ts
Outdated
Show resolved
Hide resolved
code/frameworks/angular/src/client/angular-beta/utils/PropertyExtractor.ts
Outdated
Show resolved
Hide resolved
code/frameworks/angular/src/client/angular-beta/utils/PropertyExtractor.ts
Outdated
Show resolved
Hide resolved
code/frameworks/angular/src/client/angular-beta/utils/PropertyExtractor.ts
Show resolved
Hide resolved
@sheriffMoose Well done 🥳 I left some minor comments. Did you figure out the caching issue locally? |
@valentinpalkovic yep, I created a new empty clone on a different machine |
code/frameworks/angular/src/client/angular-beta/utils/PropertyExtractor.ts
Outdated
Show resolved
Hide resolved
code/frameworks/angular/src/client/angular-beta/utils/PropertyExtractor.ts
Outdated
Show resolved
Hide resolved
code/frameworks/angular/src/client/angular-beta/utils/PropertyExtractor.ts
Outdated
Show resolved
Hide resolved
4804f14
to
571f051
Compare
fix imports/providers without caching componentNgModule
`imports`/`declarations` will be used only once per story file. while `providers` will be used for each story rendered.
571f051
to
e7dedce
Compare
Issue: N/A
Use Angular Providers in bootstrapApplication option and rework the way of how imports are initialized for the Angular Storybook standalone wrapper.
What I did
How to test
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]