Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify consistency of anonymous id #20781

Merged
merged 2 commits into from
Jan 25, 2023
Merged

Verify consistency of anonymous id #20781

merged 2 commits into from
Jan 25, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Jan 25, 2023

Issue: N/A

What I did

  • Trim whitespace in git URLs
  • Verify anon id reported in testing matches our expectation.

How to test

Let's see what happens in CI. Can you also run the following locally:

  1. yarn ts-node ./event-log-collector.ts (in scripts)
  2. yarn task --task build --template react-vite/default-js --start-from install
  3. yarn ts-node ./event-log-checker build react-vite/default-js (in scripts)

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday added telemetry build Internal-facing build tooling & test updates labels Jan 25, 2023
@tmeasday tmeasday requested a review from shilman January 25, 2023 11:04
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 💯

@shilman shilman merged commit cf3ab50 into next Jan 25, 2023
@shilman shilman deleted the test-sandbox-storybook-id branch January 25, 2023 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates telemetry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants