-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nunito sans font #20846
Add nunito sans font #20846
Conversation
…he template Co-authored-by: Valentin Palkovic <valentin@chromatic.com>
I was instructed to use "Regular" and "Black" variation, thus that's the fonts-files I added. @MichaelArestad can you please comment? |
I updated the typefaces to include Regular, Italic, Bold, and Bold Italic. I removed black and updated the few places the 900 weight was used.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
No, I have no concerns about that at all.
This PR doesn't impact the preview (where docs renders) at all. Am I correct in assuming you want me to apply this font-loading change to for the preview as well? @MichaelArestad |
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
@ndelangen Yes, please. The only fonts the manager use are regular and bold. Only the docs pages would utilize the italic variants. |
@ndelangen Thank you, Norbert, for taking care of the requested changes. Should we merge? :) |
Resolve: #20828
Resolve: #16278
What I did
How to test
repeat the above steps but for a build storybook. (you can use a chromatic deployed storybook for this)