-
-
Notifications
You must be signed in to change notification settings - Fork 9.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs: Show source of corresponding args in source block #20915
Conversation
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good.
Still concerned about this though #20745 (comment)
This would require all renderers to change right, even the community ones we don't control?
@JReinhold note the fallback to "unknown args" when we don't receive args details on the channel message. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Only a minor nit.
@shilman as discussed, the E2E test I added here which inspects the arg value in the snippet is failing in various frameworks that don't appear to be rendering the snippet (should contain something like
In Vue it renders the right thing but never updates based on args changes. It looks like the |
Closes #20745
What I did
SNIPPET_RENDERED
event__forceInitialArgs
is passed toSource
(in which case read oninitialArgs
).__forceInitialArgs
through.How to test
See stories & E2E tests. Try changing args on docs page with source open and check only the primary story changes.
Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]