Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(angular): changeDetectorRef should be defined #20984

Merged
merged 1 commit into from
Feb 7, 2023
Merged

fix(angular): changeDetectorRef should be defined #20984

merged 1 commit into from
Feb 7, 2023

Conversation

sheriffMoose
Copy link
Contributor

@sheriffMoose sheriffMoose commented Feb 7, 2023 •
edited by valentinpalkovic
Loading

Resolves #20931
Resolves #21015

What I did

  • fix an issue where changeDetectorRef is undefined, this makes lifeCycleHooks ineffective

How to test

  • CI Passes

@valentinpalkovic valentinpalkovic merged commit 78c3032 into storybookjs:next Feb 7, 2023
@shilman shilman mentioned this pull request Feb 7, 2023
Closed
@valentinpalkovic valentinpalkovic mentioned this pull request Feb 8, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@valentinpalkovic valentinpalkovic valentinpalkovic approved these changes

Assignees
No one assigned
Labels
angular bug
Projects
None yet
Milestone
No milestone
2 participants
@sheriffMoose @valentinpalkovic