Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use Vite by default for Svelte and Vue #21002

Merged
merged 2 commits into from
Feb 16, 2023

Conversation

benmccann
Copy link
Contributor

@benmccann benmccann commented Feb 8, 2023

What I did

New Vue and Svelte projects use Vite by default. Those ecosystems are heavily invested in Vite and promote it as the default builder. If someone were creating a component library that didn't need a builder, we'd want them to use Vite with Storybook since that's what most of the users will be using and what we'd be most equipped to provide help with

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Member

@IanVS IanVS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I have two minor suggestions to consider.

code/lib/cli/src/detect.ts Outdated Show resolved Hide resolved
code/lib/cli/src/detect.ts Show resolved Hide resolved
code/lib/cli/src/detect.ts Show resolved Hide resolved
@benmccann benmccann merged commit 71d6510 into storybookjs:next Feb 16, 2023
@benmccann benmccann deleted the default-builder-2 branch February 16, 2023 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants