Fix Source View in Nextjs projects

[valentinpalkovic]

Resolves #20356

What I did

I have set the parameters.docs.source.excludeDecorators to true per default.

How to test

1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template nextjs/default-ts
2. Open Storybook in your browser
3. Access Button Docs
4. Click on "Show Code" and it should show the component code properly

Checklist

• Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
• Make sure to add/update documentation regarding your changes
• If you are deprecating/removing a feature, make sure to update
  MIGRATION.MD

Maintainers

• If this PR should be tested against many or all sandboxes,
  make sure to add the ci:merged or ci:daily GH label to it.
• Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

[JReinhold]

Was it default true in 6.5 as well and we just lost it at some point, or is this new?
If this is new I would consider this a breaking change that we need to mention in migration notes - and I think we should do it for all renderers if we want to do this.

Alternatively you could set this in the NextJS framework instead of the renderer, if it's only there it is causing trouble.

[valentinpalkovic]

I have to use the react renderer. Next.js does not have its own renderer. I don’t know about the first part of your question :/

[JReinhold]

I have to use the react renderer. Next.js does not have its own renderer.

I'm pretty sure you can set parameters in frameworks the same way you'd do it in renderes, via the preset.ts. In https://github.com/storybookjs/storybook/blob/next/code/frameworks/nextjs/src/preset.ts :

...

export const parameters = {
  docs: {
    source: {
      excludeDecorators: true,
    }
  } 
};

[valentinpalkovic]

@JReinhold Changed, but unfortunately does not have any effect (see chromatic build).

[JReinhold]

I'm still seeing weird sources in the published NextJS Storybook:

https://634ff0d0ec053b270775979d-zjgrspsocr.chromatic.com/?path=/docs/example-button--docs

Was this PR supposed to fix this, or am I missing something? Or maybe this only fixes it in dev mode?

[shilman]

@valentinpalkovic @JReinhold

• Setting the parameters should happen in preview.tsx not preset.ts
• We've never set excludeDecorators to true by default, but there's no reason we can't

[valentinpalkovic]

@shilman or @tmeasday May I get final approval? :)

[tmeasday]

Fine by me! But I think I am missing why we need to drop the decorators in next exactly? Perhaps a comment explaining why there's problematic decorators would help?

[tmeasday]

@valentinpalkovic I re-enabled the test f5d5989 and it worked great!