Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storyshots: fix issue with default export in main.js #21097

Merged
merged 3 commits into from
Feb 15, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Feb 15, 2023

Closes #21050

What I did

Check the default export and named exports for storyshots.

How to test

See test case. Or you could try on the repro on the issue.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday requested a review from ndelangen February 15, 2023 07:30
@tmeasday tmeasday changed the title Add failing test case for #21050 Storyshots: fix issue with default export in main.js Feb 15, 2023
@ndelangen ndelangen self-assigned this Feb 15, 2023
@ndelangen ndelangen merged commit 23d7fd2 into next Feb 15, 2023
@ndelangen ndelangen deleted the 21050-storyshots-default-export branch February 15, 2023 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: @storybook/addons-storyshots doesn't work with storybook 7.
2 participants