Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build: add cra preset to monorepo #21107

Merged
merged 9 commits into from
Feb 16, 2023
Merged

Build: add cra preset to monorepo #21107

merged 9 commits into from
Feb 16, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Feb 15, 2023 •
edited
Loading

Fixes: #21004

  • move the cra preset code into the monorepo
  • clean it up a bit to focus on 7.0 only
  • integrate it with the build tooling in the monorepo

@ndelangen ndelangen self-assigned this Feb 15, 2023
@ndelangen ndelangen added ci: do not merge build Internal-facing build tooling & test updates labels Feb 15, 2023
@ndelangen ndelangen requested a review from shilman February 15, 2023 17:08
@storybookjs storybookjs deleted a comment from socket-security bot Feb 15, 2023
@storybookjs storybookjs deleted a comment from socket-security bot Feb 15, 2023
@ndelangen
Copy link
Member Author

@shilman I decided to take this approach to try and fix #21004

I'd love to meet tomorrow and discuss

@ndelangen ndelangen mentioned this pull request Feb 16, 2023
Closed
@ndelangen ndelangen marked this pull request as ready for review February 16, 2023 08:44
@ndelangen ndelangen added bug presets cra Prioritize create-react-app compatibility and removed ci: do not merge labels Feb 16, 2023
@storybookjs storybookjs deleted a comment from socket-security bot Feb 16, 2023
@ndelangen ndelangen removed the build Internal-facing build tooling & test updates label Feb 16, 2023
@storybookjs storybookjs deleted a comment from socket-security bot Feb 16, 2023
@ndelangen
Copy link
Member Author

@shilman self-merging

@ndelangen ndelangen merged commit 683dad6 into next Feb 16, 2023
@ndelangen ndelangen deleted the norbert/cra-preset-internal branch February 16, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman Awaiting requested review from shilman

Assignees

@ndelangen ndelangen

Labels
bug cra Prioritize create-react-app compatibility presets
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fresh CRA fails in npm8 on beta.44
2 participants
@ndelangen @yannbf