Fix static dirs look up in Next.js projects #21119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20938
What I did
We found that the middleware for static paths was not awaited, and coult potentially be injected as middleware too-late.
After that fix didn't make the issue go away, we investigated the failure further and found out the true reason why it was failing.. a bad if statement in the
useStaticsfunction itself, was checking the wrong thing, and causedstaticsto be undefined.How to test
Running a nextjs sandbox should show the proper fonts, and not have any 404's for fonts or CSS.