Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Account for legacy framework values in automigration #21184

Merged
merged 1 commit into from
Feb 27, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 21, 2023

What I did

The automigrations were not account for a legacy framework value such as:

export default {
  framework: 'react'
}

So this PR fixes that (and fixes a small regression regarding community frameworks)

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. Change the framework field to react
  3. Run automigrations

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! 💯

@yannbf yannbf force-pushed the fix/automigrate-account-for-legacy-framework branch from 5a72ea1 to c0b2b34 Compare February 27, 2023 17:05
@yannbf yannbf merged commit 3ef8a7a into next Feb 27, 2023
@yannbf yannbf deleted the fix/automigrate-account-for-legacy-framework branch February 27, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants