-
-
Notifications
You must be signed in to change notification settings - Fork 9.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI: Add automigration for GFM in MDX #21186
Conversation
…migration adding it
Socket Security Pull Request Report👍 No new dependency issues detected in pull request Pull request report summary
Bot CommandsTo ignore an alert, reply with a comment starting with Powered by socket.dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This generally LGTM.
Two points:
- @yannbf should def review this as he's up on all the latest subtleties around modifying
main.js
- any chance we can add the new addon OUTSIDE of the monorepo? i understand the reasons not to, but the monorepo is just getting bigger & bigger...
Good stuff @ndelangen ! I made some changes regarding bug fixes and documentation. |
Closes #20091
What I did
I've added an automigration that adds GFM support to addon-docs via adding an addon
I've created the addon that adds GFM config
The addon is a tool to assist users migrate, it's not supposed to be used indefinitely.
The reaosn we did it this way, is because it made writing the auto-migration much much much easier. User will have to do a manual step, but it should get them into a working state
How to test
After running the automigration you should get an extra addon in your addon array
You should also heb the addon added to your package.json
Your storybook should now support GFM without having to configure addon-docs.
There should be a deprecation notice in the command-loine telling you (once again) that you should perform the manual migration.