Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: add @storybook/bench #21199

Merged
merged 2 commits into from
Feb 22, 2023
Merged

Build: add @storybook/bench #21199

merged 2 commits into from
Feb 22, 2023

Conversation

JReinhold
Copy link
Contributor

@JReinhold JReinhold commented Feb 22, 2023

What I did

This PR adds @storybook/bench as a dependency in the monorepo, in an attempt to ensure that the benchmark follows the dependency resolutions when running (specifically playwright). It also makes the CI run the locally installed bench instead of using npx.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold self-assigned this Feb 22, 2023
@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Feb 22, 2023
@socket-security
Copy link

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package Script field Source
puppeteer@5.5.0 (added) install code/package.json via @storybook/bench@0.7.5
⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package Eval Type Location Source
puppeteer@5.5.0 (added) Function lib/cjs/puppeteer/common/DOMWorld.js code/package.json via @storybook/bench@0.7.5
puppeteer@5.5.0 (added) Function lib/cjs/puppeteer/common/ExecutionContext.js code/package.json via @storybook/bench@0.7.5
puppeteer@5.5.0 (added) Function lib/esm/puppeteer/common/DOMWorld.js code/package.json via @storybook/bench@0.7.5
puppeteer@5.5.0 (added) Function lib/esm/puppeteer/common/ExecutionContext.js code/package.json via @storybook/bench@0.7.5
puppeteer-core@18.2.1 (added) Function lib/cjs/puppeteer/common/ExecutionContext.js code/package.json via @storybook/addon-storyshots-puppeteer@6.5.16, code/addons/storyshots-puppeteer/package.json via @axe-core/puppeteer@4.6.0
puppeteer-core@18.2.1 (added) Function lib/cjs/puppeteer/common/ExecutionContext.js code/package.json via @storybook/addon-storyshots-puppeteer@6.5.16, code/addons/storyshots-puppeteer/package.json via @axe-core/puppeteer@4.6.0
puppeteer-core@18.2.1 (added) Function lib/esm/puppeteer/common/ExecutionContext.js code/package.json via @storybook/addon-storyshots-puppeteer@6.5.16, code/addons/storyshots-puppeteer/package.json via @axe-core/puppeteer@4.6.0
puppeteer-core@18.2.1 (added) Function lib/esm/puppeteer/common/ExecutionContext.js code/package.json via @storybook/addon-storyshots-puppeteer@6.5.16, code/addons/storyshots-puppeteer/package.json via @axe-core/puppeteer@4.6.0
puppeteer-core@2.1.1 (added) Function lib/Browser.js code/package.json via @storybook/cli@6.5.16, code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.53, code/frameworks/angular/package.json via @storybook/cli@7.0.0-beta.53, code/lib/cli/package.json, code/lib/cli-sb/package.json via @storybook/cli@7.0.0-beta.53, code/lib/cli-storybook/package.json via @storybook/cli@7.0.0-beta.53, test-storybooks/ember-cli/package.json via storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
puppeteer-core@2.1.1 (added) Function lib/DOMWorld.js code/package.json via @storybook/cli@6.5.16, code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.53, code/frameworks/angular/package.json via @storybook/cli@7.0.0-beta.53, code/lib/cli/package.json, code/lib/cli-sb/package.json via @storybook/cli@7.0.0-beta.53, code/lib/cli-storybook/package.json via @storybook/cli@7.0.0-beta.53, test-storybooks/ember-cli/package.json via storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
puppeteer-core@2.1.1 (added) Function lib/ExecutionContext.js code/package.json via @storybook/cli@6.5.16, code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.53, code/frameworks/angular/package.json via @storybook/cli@7.0.0-beta.53, code/lib/cli/package.json, code/lib/cli-sb/package.json via @storybook/cli@7.0.0-beta.53, code/lib/cli-storybook/package.json via @storybook/cli@7.0.0-beta.53, test-storybooks/ember-cli/package.json via storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
puppeteer-core@2.1.1 (added) Function lib/ExecutionContext.js code/package.json via @storybook/cli@6.5.16, code/addons/storyshots-core/package.json via @storybook/angular@7.0.0-beta.53, code/frameworks/angular/package.json via @storybook/cli@7.0.0-beta.53, code/lib/cli/package.json, code/lib/cli-sb/package.json via @storybook/cli@7.0.0-beta.53, code/lib/cli-storybook/package.json via @storybook/cli@7.0.0-beta.53, test-storybooks/ember-cli/package.json via storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
react-inspector@5.1.1 (added) Function dist/cjs/react-inspector.js code/package.json via @storybook/addon-actions@6.5.16, @storybook/addon-essentials@6.5.16
react-inspector@5.1.1 (added) Function dist/es/react-inspector.js code/package.json via @storybook/addon-actions@6.5.16, @storybook/addon-essentials@6.5.16
react-resize-detector@7.1.2 (added) Function build/index.esm.js code/addons/a11y/package.json, code/addons/jest/package.json, code/ui/manager/package.json
react-resize-detector@7.1.2 (added) Function build/index.js code/addons/a11y/package.json, code/addons/jest/package.json, code/ui/manager/package.json
regenerator-runtime@0.11.1 (added) Function runtime-module.js code/addons/storyshots-core/package.json via jest-vue-preprocessor@1.7.1
rollup@2.79.1 (added) Function dist/shared/loadConfigFile.js code/package.json via @storybook/builder-vite@0.4.2, @storybook/preset-create-react-app@4.1.2, @vitejs/plugin-react@2.2.0, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/preact-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/react-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.53, @storybook/svelte-vite@7.0.0-beta.53, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/presets/create-react-app/package.json via react-scripts@5.0.1
rollup@2.79.1 (added) Function dist/shared/loadConfigFile.js code/package.json via @storybook/builder-vite@0.4.2, @storybook/preset-create-react-app@4.1.2, @vitejs/plugin-react@2.2.0, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/preact-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/react-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.53, @storybook/svelte-vite@7.0.0-beta.53, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/presets/create-react-app/package.json via react-scripts@5.0.1
rollup@3.17.2 (added) Function dist/shared/loadConfigFile.js code/package.json via @storybook/builder-vite@0.4.2, vite@4.1.4, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/preact-vite/package.json via @preact/preset-vite@2.5.0, @storybook/builder-vite@7.0.0-beta.53, vite@4.1.4, code/frameworks/react-vite/package.json via @joshwooding/vite-plugin-react-docgen-typescript@0.2.1, @storybook/builder-vite@7.0.0-beta.53, @vitejs/plugin-react@3.1.0, vite@4.1.4, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, @sveltejs/vite-plugin-svelte@2.0.2, vite@4.1.4, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.53, @storybook/svelte-vite@7.0.0-beta.53, vite@4.1.4, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, vite@4.1.4, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, @vitejs/plugin-vue@4.0.0, vite@4.1.4, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/lib/builder-vite/package.json via @preact/preset-vite@2.5.0, vite@4.1.4, scripts/package.json via tsup@6.6.3
rollup@3.17.2 (added) Function dist/shared/loadConfigFile.js code/package.json via @storybook/builder-vite@0.4.2, vite@4.1.4, code/frameworks/html-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/frameworks/preact-vite/package.json via @preact/preset-vite@2.5.0, @storybook/builder-vite@7.0.0-beta.53, vite@4.1.4, code/frameworks/react-vite/package.json via @joshwooding/vite-plugin-react-docgen-typescript@0.2.1, @storybook/builder-vite@7.0.0-beta.53, @vitejs/plugin-react@3.1.0, vite@4.1.4, code/frameworks/svelte-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, @sveltejs/vite-plugin-svelte@2.0.2, vite@4.1.4, code/frameworks/sveltekit/package.json via @storybook/builder-vite@7.0.0-beta.53, @storybook/svelte-vite@7.0.0-beta.53, vite@4.1.4, code/frameworks/vue-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, vite@4.1.4, code/frameworks/vue3-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, @vitejs/plugin-vue@4.0.0, vite@4.1.4, code/frameworks/web-components-vite/package.json via @storybook/builder-vite@7.0.0-beta.53, code/lib/builder-vite/package.json via @preact/preset-vite@2.5.0, vite@4.1.4, scripts/package.json via tsup@6.6.3
svelte-check@2.10.3 (added) Function dist/src/index.js code/renderers/svelte/package.json
svelte-check@2.10.3 (added) Function dist/src/index.js code/renderers/svelte/package.json
svelte-check@2.10.3 (added) Function dist/src/index.js code/renderers/svelte/package.json
symbol-observable@4.0.0 (added) Function es/index.js code/frameworks/angular/package.json via @angular/cli@15.1.6
symbol-observable@4.0.0 (added) Function lib/index.js code/frameworks/angular/package.json via @angular/cli@15.1.6
telejson@6.0.8 (added) Function dist/cjs/index.js code/package.json via @storybook/addon-a11y@6.5.16, @storybook/addon-actions@6.5.16, @storybook/addon-backgrounds@6.5.16, @storybook/addon-controls@6.5.16, @storybook/addon-docs@6.5.16, @storybook/addon-essentials@6.5.16, @storybook/addon-interactions@6.5.16, @storybook/addon-jest@6.5.16, @storybook/addon-links@6.5.16, @storybook/addon-measure@6.5.16, @storybook/addon-outline@6.5.16, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/addon-storysource@6.5.16, @storybook/addon-toolbars@6.5.16, @storybook/addon-viewport@6.5.16, @storybook/addons@6.5.16, @storybook/angular@6.5.16, @storybook/api@6.5.16, @storybook/builder-vite@0.4.2, @storybook/builder-webpack5@6.5.16, @storybook/channel-postmessage@6.5.16, @storybook/channel-websocket@6.5.16, @storybook/cli@6.5.16, @storybook/client-api@6.5.16, @storybook/core-client@6.5.16, @storybook/core-common@6.5.16, @storybook/core-server@6.5.16, @storybook/docs-tools@6.5.16, @storybook/ember@6.5.16, @storybook/html@6.5.16, @storybook/instrumenter@6.5.16, @storybook/jest@0.0.10, @storybook/preact@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/preview-web@6.5.16, @storybook/react@6.5.16, @storybook/server@6.5.16, @storybook/source-loader@6.5.16, @storybook/store@6.5.16, @storybook/svelte@6.5.16, @storybook/telemetry@6.5.16, @storybook/testing-library@0.0.13, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, @storybook/web-components@6.5.16, code/addons/interactions/package.json via @storybook/jest@0.0.10, @storybook/testing-library@0.0.13, code/addons/storyshots-puppeteer/package.json via @storybook/addon-storyshots@7.0.0-beta.53, scripts/package.json via @storybook/jest@0.0.10, @storybook/testing-library@0.0.13, test-storybooks/ember-cli/package.json via @storybook/addon-a11y@7.0.0-alpha.43, @storybook/addon-actions@7.0.0-alpha.43, @storybook/addon-backgrounds@7.0.0-alpha.43, @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-highlight@7.0.0-alpha.43, @storybook/addon-links@7.0.0-alpha.43, @storybook/addon-storysource@7.0.0-alpha.43, @storybook/addon-viewport@7.0.0-alpha.43, @storybook/addons@7.0.0-alpha.43, @storybook/ember@7.0.0-alpha.43, storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-essentials@7.0.0-alpha.43, @storybook/blocks@7.0.0-alpha.43, @storybook/preview-web@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via @storybook/addon-a11y@7.0.0-alpha.43, @storybook/addon-actions@7.0.0-alpha.43, @storybook/addon-backgrounds@7.0.0-alpha.43, @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-highlight@7.0.0-alpha.43, @storybook/addon-links@7.0.0-alpha.43, @storybook/server@7.0.0-alpha.43, @storybook/server-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/addon-docs@7.0.0-alpha.43, @storybook/cli@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43
telejson@6.0.8 (added) Function dist/esm/index.js code/package.json via @storybook/addon-a11y@6.5.16, @storybook/addon-actions@6.5.16, @storybook/addon-backgrounds@6.5.16, @storybook/addon-controls@6.5.16, @storybook/addon-docs@6.5.16, @storybook/addon-essentials@6.5.16, @storybook/addon-interactions@6.5.16, @storybook/addon-jest@6.5.16, @storybook/addon-links@6.5.16, @storybook/addon-measure@6.5.16, @storybook/addon-outline@6.5.16, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/addon-storysource@6.5.16, @storybook/addon-toolbars@6.5.16, @storybook/addon-viewport@6.5.16, @storybook/addons@6.5.16, @storybook/angular@6.5.16, @storybook/api@6.5.16, @storybook/builder-vite@0.4.2, @storybook/builder-webpack5@6.5.16, @storybook/channel-postmessage@6.5.16, @storybook/channel-websocket@6.5.16, @storybook/cli@6.5.16, @storybook/client-api@6.5.16, @storybook/core-client@6.5.16, @storybook/core-common@6.5.16, @storybook/core-server@6.5.16, @storybook/docs-tools@6.5.16, @storybook/ember@6.5.16, @storybook/html@6.5.16, @storybook/instrumenter@6.5.16, @storybook/jest@0.0.10, @storybook/preact@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/preview-web@6.5.16, @storybook/react@6.5.16, @storybook/server@6.5.16, @storybook/source-loader@6.5.16, @storybook/store@6.5.16, @storybook/svelte@6.5.16, @storybook/telemetry@6.5.16, @storybook/testing-library@0.0.13, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, @storybook/web-components@6.5.16, code/addons/interactions/package.json via @storybook/jest@0.0.10, @storybook/testing-library@0.0.13, code/addons/storyshots-puppeteer/package.json via @storybook/addon-storyshots@7.0.0-beta.53, scripts/package.json via @storybook/jest@0.0.10, @storybook/testing-library@0.0.13, test-storybooks/ember-cli/package.json via @storybook/addon-a11y@7.0.0-alpha.43, @storybook/addon-actions@7.0.0-alpha.43, @storybook/addon-backgrounds@7.0.0-alpha.43, @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-highlight@7.0.0-alpha.43, @storybook/addon-links@7.0.0-alpha.43, @storybook/addon-storysource@7.0.0-alpha.43, @storybook/addon-viewport@7.0.0-alpha.43, @storybook/addons@7.0.0-alpha.43, @storybook/ember@7.0.0-alpha.43, storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-essentials@7.0.0-alpha.43, @storybook/blocks@7.0.0-alpha.43, @storybook/preview-web@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via @storybook/addon-a11y@7.0.0-alpha.43, @storybook/addon-actions@7.0.0-alpha.43, @storybook/addon-backgrounds@7.0.0-alpha.43, @storybook/addon-controls@7.0.0-alpha.43, @storybook/addon-highlight@7.0.0-alpha.43, @storybook/addon-links@7.0.0-alpha.43, @storybook/server@7.0.0-alpha.43, @storybook/server-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/addon-docs@7.0.0-alpha.43, @storybook/cli@7.0.0-alpha.43, @storybook/react@7.0.0-alpha.43, @storybook/react-webpack5@7.0.0-alpha.43, storybook@7.0.0-alpha.43
telejson@7.0.4 (added) Function dist/index.js code/addons/a11y/package.json via @storybook/addon-highlight@7.0.0-beta.53, @storybook/manager-api@7.0.0-beta.53, @storybook/preview-api@7.0.0-beta.53, code/addons/actions/package.json via @storybook/manager-api@7.0.0-beta.53, @storybook/preview-api@7.0.0-beta.53, code/addons/backgrounds/package.json via @storybook/manager-api@7.0.0-beta.53, @storybook/preview-api@7.0.0-beta.53, code/addons/controls/package.json via @storybook/blocks@7.0.0-beta.53, @storybook/manager-api@7.0.0-beta.53, @storybook/preview-api@7.0.0-beta.53, code/addons/docs/package.json via @storybook/blocks@7.0.0-beta.53, @storybook/preview-api@7.0.0-beta.53, code/addons/essentials/package.json via @storybook/addon-actions@7.0.0-beta.53, @storybook/addon-backgrounds@7.0.0-beta.53, @storybook/addon-controls@7.0.0-beta.53, @storybook/addon-docs@7.0.0-beta.53, @storybook/addon-highlight@7.0.0-beta.53, @storybook/addon-measure@7.0.0-beta.53, @storybook/addon-outline@7.0.0-beta.53, @storybook/addon-toolbars@7.0.0-beta.53, @storybook/addon-viewport@7.0.0-beta.53, @storybook/manager-api@7.0.0-beta.53, [@storybook/preview-api@7.0.0-beta.53](https://socket.dev/npm/package/@storybook

@JReinhold JReinhold merged commit 87c2598 into next Feb 22, 2023
@JReinhold JReinhold deleted the fix-playwright-again branch February 22, 2023 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants