Build: upgrade playwright & re-enable bench

[ndelangen]

replaces: #21240 ?

[shilman]

@ndelangen this doesn't revert @JReinhold 's changes tho? not sure if it's an issue

[ndelangen]

@shilman seems to go green?

[ndelangen]

the CRA bench seems to time out

[ndelangen]

Uncaught (in promise) TypeError: Failed to fetch
    at logEvent (vendors-node_modules_pmmmwh_react-refresh-webpack-plugin_client_ErrorOverlayEntry_js-node_mod-074d72.iframe.bundle.js:2075:3)
    at ./node_modules/@storybook/addon-bench/dist/preview.js (vendors-node_modules_pmmmwh_react-refresh-webpack-plugin_client_ErrorOverlayEntry_js-node_mod-074d72.iframe.bundle.js:2040:23)
    at options.factory (runtime~main.iframe.bundle.js:615:31)
    at __webpack_require__ (runtime~main.iframe.bundle.js:28:33)
    at fn (runtime~main.iframe.bundle.js:298:25)
    at Object.getProjectAnnotations [as nextFn] (main.iframe.bundle.js:234:75)
    at runtime.mjs:4:78491
    at Array.forEach (<anonymous>)
    at SynchronousPromise4._runResolutions (runtime.mjs:4:78432)
    at SynchronousPromise4.then (runtime.mjs:4:75974)

[ndelangen]

I downloaded the CRA bench, linked it to local verdaccio, and ran it, and it opened fine, except that the bench addon is causing issues.
If I remove the bench addon from main it works fine.

I don't know why the CI is timing out, it would suggest there's some issue happening in the playwright browser, but I can't really reproduce what.

[socket-security]

Socket Security Pull Request Report

Dependency issues detected: If you merge this pull request, you will not be alerted to the instances of these issues again.

📜 Install scripts

Install scripts are run when the package is installed. The majority of malware in npm is hidden in install scripts.

Packages should not be running non-essential scripts during install and there are often solutions to problems people solve with install scripts that can be run at publish time instead.

Package	Script field	Source
playwright@1.31.1 (upgraded)	install	code/package.json
puppeteer@3.3.0 (added)	install	code/addons/storyshots-puppeteer/package.json
puppeteer@5.5.0 (added)	install	code/package.json via @storybook/bench@0.7.5

😵‍💫 Bin script confusion

This package has multiple bin scripts with the same name. This can cause non-deterministic behavior when installing or could be a sign of a supply chain attack

Consider removing one of the conflicting packages. Packages should only export bin scripts with their name

Package	Bin script	Source
@playwright/test@1.31.1 (upgraded)	playwright	code/package.json
playwright@1.31.1 (upgraded)	playwright	code/package.json
playwright-core@1.31.1 (upgraded)	playwright	code/package.json via @playwright/test@1.31.1, playwright@1.31.1

⚠️ Uses eval

Package uses eval() which is a dangerous function. This prevents the code from running in certain environments and increases the risk that the code may contain exploits or malicious behavior.

Avoid packages that use eval, since this could potentially execute any code.

Package	Eval Type	Location	Source
playwright-core@1.31.1 (upgraded)	Function	lib/server/javascript.js	code/package.json via @playwright/test@1.31.1, playwright@1.31.1
playwright-core@1.31.1 (upgraded)	Function	lib/server/javascript.js	code/package.json via @playwright/test@1.31.1, playwright@1.31.1
pngjs@6.0.0 (added)	Function	browser.js	code/package.json via @storybook/addon-storyshots-puppeteer@6.5.16, jest-image-snapshot@6.1.0, code/addons/storyshots-puppeteer/package.json via jest-image-snapshot@6.1.0, scripts/package.json via jest-image-snapshot@6.1.0
pngjs@6.0.0 (added)	Function	browser.js	code/package.json via @storybook/addon-storyshots-puppeteer@6.5.16, jest-image-snapshot@6.1.0, code/addons/storyshots-puppeteer/package.json via jest-image-snapshot@6.1.0, scripts/package.json via jest-image-snapshot@6.1.0
postcss-loader@6.2.1 (added)	Function	dist/utils.js	code/package.json via @storybook/preset-create-react-app@4.1.2, code/presets/create-react-app/package.json via react-scripts@5.0.1
postcss-loader@7.0.2 (added)	Function	dist/utils.js	code/package.json via @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, code/addons/storyshots-core/package.json via jest-preset-angular@13.0.0, code/frameworks/angular/package.json via @angular-devkit/build-angular@15.2.0, jest-preset-angular@12.2.6, code/frameworks/nextjs/package.json
postcss-loader@7.0.2 (added)	Function	dist/utils.js	code/package.json via @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, code/addons/storyshots-core/package.json via jest-preset-angular@13.0.0, code/frameworks/angular/package.json via @angular-devkit/build-angular@15.2.0, jest-preset-angular@12.2.6, code/frameworks/nextjs/package.json
postcss-loader@7.0.2 (added)	Function	dist/utils.js	code/package.json via @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, code/addons/storyshots-core/package.json via jest-preset-angular@13.0.0, code/frameworks/angular/package.json via @angular-devkit/build-angular@15.2.0, jest-preset-angular@12.2.6, code/frameworks/nextjs/package.json
prettier@2.3.0 (added)	Function	bin-prettier.js	code/package.json via @storybook/addon-docs@6.5.16, @storybook/addon-essentials@6.5.16, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/addon-storysource@6.5.16, @storybook/angular@6.5.16, @storybook/builder-vite@0.4.2, @storybook/cli@6.5.16, @storybook/codemod@6.5.16, @storybook/core-server@6.5.16, @storybook/csf-tools@6.5.16, @storybook/ember@6.5.16, @storybook/html@6.5.16, @storybook/preact@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/react@6.5.16, @storybook/server@6.5.16, @storybook/source-loader@6.5.16, @storybook/svelte@6.5.16, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, @storybook/web-components@6.5.16, test-storybooks/ember-cli/package.json via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-storysource@7.0.0-alpha.43, @storybook/source-loader@7.0.0-alpha.43, storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via @storybook/addon-docs@7.0.0-alpha.43, @storybook/addon-essentials@7.0.0-alpha.43, storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/addon-docs@7.0.0-alpha.43, @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
prettier@2.8.0 (added)	Function	index.js	code/package.json via @nrwl/workspace@15.7.2, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, @storybook/eslint-config-storybook@3.1.2, @storybook/linter-config@3.1.2, @storybook/vue@6.5.16, code/addons/storyshots-core/package.json via vue-jest@4.0.1, code/frameworks/vue-webpack5/package.json via vue-loader@15.10.1, code/lib/cli/package.json, code/lib/codemod/package.json, code/lib/source-loader/package.json, code/presets/vue-webpack/package.json via vue-loader@15.10.1, code/ui/components/package.json
prettier@2.8.0 (added)	Function	index.js	code/package.json via @nrwl/workspace@15.7.2, @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/angular@6.5.16, @storybook/eslint-config-storybook@3.1.2, @storybook/linter-config@3.1.2, @storybook/vue@6.5.16, code/addons/storyshots-core/package.json via vue-jest@4.0.1, code/frameworks/vue-webpack5/package.json via vue-loader@15.10.1, code/lib/cli/package.json, code/lib/codemod/package.json, code/lib/source-loader/package.json, code/presets/vue-webpack/package.json via vue-loader@15.10.1, code/ui/components/package.json
prettier@2.8.4 (added)	Function	cli.js	scripts/package.json via @nrwl/workspace@15.7.2, @storybook/eslint-config-storybook@3.1.2, @storybook/linter-config@3.1.2
pretty-format@27.5.1 (added)	Function	build/plugins/AsymmetricMatcher.js	code/package.json via @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/testing-library@0.0.13, jest@29.4.3, jest-image-snapshot@6.1.0, jest-watch-typeahead@2.2.2, code/addons/interactions/package.json via @storybook/testing-library@0.0.13, code/addons/storyshots-core/package.json via jest@26.6.3, jest-preset-angular@13.0.0, jest-specific-snapshot@7.0.0, vue-jest@4.0.1, code/addons/storyshots-puppeteer/package.json via jest-image-snapshot@6.1.0, code/frameworks/angular/package.json via jest@28.1.3, jest-preset-angular@12.2.6, jest-specific-snapshot@7.0.0, code/frameworks/react-webpack5/package.json via jest-specific-snapshot@7.0.0, code/lib/codemod/package.json via jest@29.4.3, jest-specific-snapshot@7.0.0, code/lib/core-server/package.json via jest-specific-snapshot@7.0.0, code/lib/docs-tools/package.json via jest-specific-snapshot@7.0.0, code/lib/postinstall/package.json via jest@29.4.3, jest-specific-snapshot@7.0.0, code/lib/source-loader/package.json via jest-specific-snapshot@7.0.0, code/presets/create-react-app/package.json via react-scripts@5.0.1, code/presets/server-webpack/package.json via jest-specific-snapshot@7.0.0, code/renderers/react/package.json via jest-specific-snapshot@7.0.0, code/renderers/vue3/package.json via @vue/vue3-jest@29.2.2, scripts/package.json via @storybook/testing-library@0.0.13
pretty-format@27.5.1 (added)	Function	build/plugins/ReactTestComponent.js	code/package.json via @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/preset-create-react-app@4.1.2, @storybook/testing-library@0.0.13, jest@29.4.3, jest-image-snapshot@6.1.0, jest-watch-typeahead@2.2.2, code/addons/interactions/package.json via @storybook/testing-library@0.0.13, code/addons/storyshots-core/package.json via jest@26.6.3, jest-preset-angular@13.0.0, jest-specific-snapshot@7.0.0, vue-jest@4.0.1, code/addons/storyshots-puppeteer/package.json via jest-image-snapshot@6.1.0, code/frameworks/angular/package.json via jest@28.1.3, jest-preset-angular@12.2.6, jest-specific-snapshot@7.0.0, code/frameworks/react-webpack5/package.json via jest-specific-snapshot@7.0.0, code/lib/codemod/package.json via jest@29.4.3, jest-specific-snapshot@7.0.0, code/lib/core-server/package.json via jest-specific-snapshot@7.0.0, code/lib/docs-tools/package.json via jest-specific-snapshot@7.0.0, code/lib/postinstall/package.json via jest@29.4.3, jest-specific-snapshot@7.0.0, code/lib/source-loader/package.json via jest-specific-snapshot@7.0.0, code/presets/create-react-app/package.json via react-scripts@5.0.1, code/presets/server-webpack/package.json via jest-specific-snapshot@7.0.0, code/renderers/react/package.json via jest-specific-snapshot@7.0.0, code/renderers/vue3/package.json via @vue/vue3-jest@29.2.2, scripts/package.json via @storybook/testing-library@0.0.13
property-expr@2.0.5 (added)	Function	compiler.js	scripts/package.json via verdaccio@5.21.1
property-expr@2.0.5 (added)	Function	compiler.js	scripts/package.json via verdaccio@5.21.1
pug@3.0.2 (added)	Function	lib/index.js	code/package.json via @storybook/addon-storyshots@6.5.16, @storybook/addon-storyshots-puppeteer@6.5.16, @storybook/builder-vite@0.4.2, @storybook/vue@6.5.16, @storybook/vue3@6.5.16, code/frameworks/vue-vite/package.json via vue-docgen-api@4.56.4, code/frameworks/vue3-vite/package.json via vue-docgen-api@4.56.4, code/presets/vue-webpack/package.json via vue-docgen-api@4.56.4, vue-docgen-loader@1.5.1, code/presets/vue3-webpack/package.json via vue-docgen-api@4.56.4, vue-docgen-loader@1.5.1, code/renderers/svelte/package.json via svelte-check@2.10.3, test-storybooks/server-kitchen-sink/package.json
puppeteer@3.3.0 (added)	Function	lib/DOMWorld.js	code/addons/storyshots-puppeteer/package.json
puppeteer@3.3.0 (added)	Function	lib/ExecutionContext.js	code/addons/storyshots-puppeteer/package.json
puppeteer@5.5.0 (added)	Function	lib/cjs/puppeteer/common/DOMWorld.js	code/package.json via @storybook/bench@0.7.5
puppeteer@5.5.0 (added)	Function	lib/cjs/puppeteer/common/ExecutionContext.js	code/package.json via @storybook/bench@0.7.5
puppeteer@5.5.0 (added)	Function	lib/esm/puppeteer/common/DOMWorld.js	code/package.json via @storybook/bench@0.7.5
puppeteer@5.5.0 (added)	Function	lib/esm/puppeteer/common/ExecutionContext.js	code/package.json via @storybook/bench@0.7.5
puppeteer-core@18.2.1 (added)	Function	lib/cjs/puppeteer/common/ExecutionContext.js	code/package.json via @storybook/addon-storyshots-puppeteer@6.5.16, code/addons/storyshots-puppeteer/package.json via @axe-core/puppeteer@4.6.0
puppeteer-core@18.2.1 (added)	Function	lib/cjs/puppeteer/common/ExecutionContext.js	code/package.json via @storybook/addon-storyshots-puppeteer@6.5.16, code/addons/storyshots-puppeteer/package.json via @axe-core/puppeteer@4.6.0
puppeteer-core@18.2.1 (added)	Function	lib/esm/puppeteer/common/ExecutionContext.js	code/package.json via @storybook/addon-storyshots-puppeteer@6.5.16, code/addons/storyshots-puppeteer/package.json via @axe-core/puppeteer@4.6.0
puppeteer-core@18.2.1 (added)	Function	lib/esm/puppeteer/common/ExecutionContext.js	code/package.json via @storybook/addon-storyshots-puppeteer@6.5.16, code/addons/storyshots-puppeteer/package.json via @axe-core/puppeteer@4.6.0
puppeteer-core@2.1.1 (added)	Function	lib/Browser.js	code/package.json via @storybook/cli@6.5.16, code/lib/cli/package.json, test-storybooks/ember-cli/package.json via storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
puppeteer-core@2.1.1 (added)	Function	lib/DOMWorld.js	code/package.json via @storybook/cli@6.5.16, code/lib/cli/package.json, test-storybooks/ember-cli/package.json via storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
puppeteer-core@2.1.1 (added)	Function	lib/ExecutionContext.js	code/package.json via @storybook/cli@6.5.16, code/lib/cli/package.json, test-storybooks/ember-cli/package.json via storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
puppeteer-core@2.1.1 (added)	Function	lib/ExecutionContext.js	code/package.json via @storybook/cli@6.5.16, code/lib/cli/package.json, test-storybooks/ember-cli/package.json via storybook@7.0.0-alpha.43, test-storybooks/external-docs/package.json via storybook@7.0.0-alpha.43, test-storybooks/server-kitchen-sink/package.json via storybook@7.0.0-alpha.43, test-storybooks/standalone-preview/package.json via @storybook/cli@7.0.0-alpha.43, storybook@7.0.0-alpha.43
react-inspector@5.1.1 (added)	Function	dist/cjs/react-inspector.js	code/package.json via @storybook/addon-actions@6.5.16, @storybook/addon-essentials@6.5.16
react-inspector@5.1.1 (added)	Function	dist/es/react-inspector.js	code/package.json via @storybook/addon-actions@6.5.16, @storybook/addon-essentials@6.5.16
react-resize-detector@7.1.2 (added)	Function	build/index.esm.js	code/addons/a11y/package.json, code/addons/jest/package.json, code/ui/manager/package.json
react-resize-detector@7.1.2 (added)	Function	build/index.js	code/addons/a11y/package.json, code/addons/jest/package.json, code/ui/manager/package.json
regenerator-runtime@0.11.1 (added)	Function	runtime-module.js	code/addons/storyshots-core/package.json via jest-vue-preprocessor@1.7.1
rollup@2.79.1 (added)	Function	dist/shared/loadConfigFile.js	code/package.json via @storybook/builder-vite@0.4.2, @storybook/preset-create-react-app@4.1.2, @vitejs/plugin-react@2.2.0, code/presets/create-react-app/package.json via react-scripts@5.0.1
rollup@2.79.1 (added)	Function	dist/shared/loadConfigFile.js	code/package.json via @storybook/builder-vite@0.4.2, @storybook/preset-create-react-app@4.1.2, @vitejs/plugin-react@2.2.0, code/presets/create-react-app/package.json via react-scripts@5.0.1
rollup@3.17.2 (added)	Function	dist/shared/loadConfigFile.js	code/package.json via @storybook/builder-vite@0.4.2, vite@4.1.4, code/frameworks/preact-vite/package.json via @preact/preset-vite@2.5.0, vite@4.1.4, code/frameworks/react-vite/package.json via @joshwooding/vite-plugin-react-docgen-typescript@0.2.1, @vitejs/plugin-react@3.1.0, vite@4.1.4, code/frameworks/svelte-vite/package.json via @sveltejs/vite-plugin-svelte@2.0.3, vite@4.1.4, code/frameworks/sveltekit/package.json via vite@4.1.4, code/frameworks/vue-vite/package.json via vite@4.1.4, code/frameworks/vue3-vite/package.json via @vitejs/plugin-vue@4.0.0, vite@4.1.4, code/lib/builder-vite/package.json via @preact/preset-vite@2.5.0, vite@4.1.4, scripts/package.json via tsup@6.6.3
rollup@3.17.2 (added)	Function	dist/shared/loadConfigFile.js	code/package.json via @storybook/builder-vite@0.4.2, vite@4.1.4, code/frameworks/preact-vite/package.json via @preact/preset-vite@2.5.0, vite@4.1.4, code/frameworks/react-vite/package.json via @joshwooding/vite-plugin-react-docgen-typescript@0.2.1, @vitejs/plugin-react@3.1.0, vite@4.1.4, code/frameworks/svelte-vite/package.json via @sveltejs/vite-plugin-svelte@2.0.3, vite@4.1.4, code/frameworks/sveltekit/package.json via vite@4.1.4, code/frameworks/vue-vite/package.json via vite@4.1.4, code/frameworks/vue3-vite/package.json via @vitejs/plugin-vue@4.0.0, vite@4.1.4, code/lib/builder-vite/package.json via @preact/preset-vite@2.5.0, vite@4.1.4, scripts/package.json via tsup@6.6.3
svelte-check@2.10.3 (added)	Function	dist/src/index.js	code/renderers/svelte/package.json
svelte-check@2.10.3 (added)	Function	dist/src/index.js	code/renderers/svelte/package.json
svelte-check@2.10.3 (added)	Function	dist/src/index.js	code/renderers/svelte/package.json
symbol-observable@4.0.0 (added)	Function	es/index.js	code/frameworks/angular/package.json via @angular/cli@15.2.0
symbol-observable@4.0.0 (added)	Function	lib/index.js	code/frameworks/angular/package.json via @angular/cli@15.2.0
telejson@6.0.8 (added)	Function	dist/cjs/index.js	code/package.json via @storybook/addon-a11y@6.5.16, @storybook/addon-actions@6.5.16, [@storybook/addon-backgrounds@6.5.16](https://socket.dev/npm/package/@storybook/addon-backgrounds/ov