Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: Improve sandbox task logs #21296

Merged
merged 1 commit into from
Feb 28, 2023
Merged

Build: Improve sandbox task logs #21296

merged 1 commit into from
Feb 28, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Feb 28, 2023

What I did

Running yarn start or yarn task --task sandbox ended with no proper feedback. This PR adds a small log that provides the needed feedback!

How to test

  1. Run a sandbox for template, e.g. yarn task --task sandbox --start-from auto --template react-vite/default-ts
  2. See the log

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added the build Internal-facing build tooling & test updates label Feb 28, 2023
@yannbf yannbf changed the title improve sandbox task logs Build: Improve sandbox task logs Feb 28, 2023
@yannbf yannbf merged commit 1be25e5 into next Feb 28, 2023
@yannbf yannbf deleted the chore/improve-sandbox-logs branch February 28, 2023 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Internal-facing build tooling & test updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants