Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CSF-tools/Codemods: Pre-bundle all babel related packages #21301

Merged
merged 6 commits into from
Mar 1, 2023
Merged

CSF-tools/Codemods: Pre-bundle all babel related packages #21301

merged 6 commits into from
Mar 1, 2023

Conversation

ndelangen
Copy link
Member

@ndelangen ndelangen commented Feb 28, 2023 •
edited
Loading

Closes #21280

What I did

I changed the babel related packages to devDependencies, as a test to see if we'd bundle in all babael related dependencies if this problem will disappear.

I can't bundle in recast, because it uses instance of, which breaks the entire runtime because a copy-class is used.
... which is honestly not exactly.. great.

How to test

  • compile packages with --no-link
  • publish to verdaccio
  • get a hold of a repro
  • make it use this package from verdaccio
  • run storybook

@ndelangen ndelangen changed the title possible fix for the error we get reported Tech: bundle in all babel related packages into csf-tools Feb 28, 2023
@ndelangen ndelangen self-assigned this Feb 28, 2023
@shilman shilman changed the title Tech: bundle in all babel related packages into csf-tools Caf-tools/Codemods: Pre-bundle all babel related packages Feb 28, 2023
shilman
shilman approved these changes Mar 1, 2023
View reviewed changes
Copy link
Member

@shilman shilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ndelangen this increases the install size by 25M which is substantial. Merging it to releasee and unblock people, but we should discuss when you're awake

@shilman shilman changed the title Caf-tools/Codemods: Pre-bundle all babel related packages CSF-tools/Codemods: Pre-bundle all babel related packages Mar 1, 2023
@shilman shilman merged commit 8d770a6 into next Mar 1, 2023
@shilman shilman deleted the norbert/fix-21280-babel-types-bundled branch March 1, 2023 00:00
@shilman shilman mentioned this pull request Mar 1, 2023
Closed
@ndelangen
Copy link
Member Author

OK, I'll do a follow up with a different experiment now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

@kasperpeulen kasperpeulen Awaiting requested review from kasperpeulen

Assignees

@ndelangen ndelangen

Labels
bug configuration babel / webpack csf
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeError: Cannot use 'in' operator to search for 'CallExpression' in undefined (beta 55)
2 participants
@ndelangen @shilman