CLI: Improve yarn/pnpm workspaces support for adding dependencies in CLI #21331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…book/dependencies in CLI
shilman
changed the title
shilman
changed the title
shilman
deleted the
norbert/20556-add-workspace-flag-to-packagemanagers-in-cli
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20556
What I did
installArgsonly for addition flags.How to test
This would require testing outside of the monorepo, in projects setup as a monorepo with the respective package managers.
I'd expect the install step to succeed now, because storybook CLI should now pass the correct flag to the package manager to set it up to allow installation into the workspace root.
I could not find if npm also required such a flag:
https://docs.npmjs.com/cli/v9/commands/npm-install#workspaces