Core: Remove state deprecation warnings by default #21367
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #20728
What I did
Move deprecation warnings for old state fields so they don't always trigger.
I wanted to have these deprecations be defined in the file that defines the relevant APIs, but it was hard to avoid a getter being called when the substate was being cloned into a larger state. There's probably a tricky way to do it, but I think this is fine. We are only concerned with people calling
useStorybookState
anyway.How to test
useStorybookState().storiesHash
in the manager somewhere, say in.storybook/manager.jsx
:Checklist
MIGRATION.MD
Maintainers
make sure to add the
ci:merged
orci:daily
GH label to it.["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]