Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix versions.ts to install latest prerelease packages #21418

Merged
merged 2 commits into from
Mar 6, 2023

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 6, 2023

Closes #21413, Closes #21410

What I did

The generate-sb-packages-versions.js script now uses lerna ls to list all monorepo packages rather than to go through every package.json manually via globs.

How to test

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf added the build Internal-facing build tooling & test updates label Mar 6, 2023
@yannbf yannbf changed the title Build: Update logic in storybook versions generation script CLI: Fix versions.ts to install latest prerelease packages Mar 6, 2023
@yannbf yannbf added bug cli and removed build Internal-facing build tooling & test updates labels Mar 6, 2023
@shilman shilman merged commit d167bbf into next Mar 6, 2023
@shilman shilman deleted the chore/check-version-consistency branch March 6, 2023 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Storybook init installs @storybook/blocks@7.0.0-alpha.8 instead of beta
2 participants