Core: Fix builders/renderer PnP support #21486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelangen
changed the title
shilman
reviewed
Mar 9, 2023
|
Nope, not possible:
the |
shilman
changed the title
ndelangen
added a commit
that referenced
this pull request
Mar 10, 2023
Revert "Merge pull request #21486 from storybookjs/norbert/wrap-for-pnp"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://discord.com/channels/486522875931656193/1081643102349049937/1081643102349049937
Here's the repro for the bug: https://github.com/ndelangen/storybook-7-vite-test
What I did
We use
dirname(require.resolve('${package}/package.json'))in a bunch of places, and actually the bug was that we forgot in som places.This makes the code look the same everywhere, using the very clear wrapForPnP function (which has to be defined locally!!!).