Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Telemetry: Replace isomorphic-unfetch with node-fetch in telemetry #21497

Merged
merged 2 commits into from
Mar 9, 2023
Merged

Telemetry: Replace isomorphic-unfetch with node-fetch in telemetry #21497

merged 2 commits into from
Mar 9, 2023

Conversation

tmeasday
Copy link
Member

@tmeasday tmeasday commented Mar 9, 2023

Closes #21432

What I did

Switch node-fetch in for telemetry.

How to test

  1. Run yarn ts-node event-log-collector from the scripts directory
  2. Run a sandbox.
  3. Check it works
  4. Add res.status(503) to the server.post('/event-log', ...
  5. Check it retries.

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@tmeasday tmeasday requested a review from shilman March 9, 2023 05:55
@shilman shilman merged commit 44284e4 into next Mar 9, 2023
@shilman shilman deleted the tom/21432-replace-isomorphic-unfetch branch March 9, 2023 09:44
@shilman shilman mentioned this pull request Mar 9, 2023
Closed
tmeasday added a commit that referenced this pull request Mar 10, 2023
@tmeasday
Revert "Merge pull request #21497 from storybookjs/tom/21432-replace-…
a1c6880 
…isomorphic-unfetch"

This reverts commit 44284e4, reversing
changes made to 99bcb2c.
shilman added a commit that referenced this pull request Mar 10, 2023
@shilman
Merge pull request #21526 from storybookjs/revert/tom/21432-replace-i…
559baf5 
…somorphic-unfetch

Revert "Merge pull request #21497 from storybookjs/tom/21432-replace-…
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shilman shilman shilman approved these changes

Assignees
No one assigned
Labels
bug telemetry
Projects
None yet
Milestone
No milestone
2 participants
@tmeasday @shilman