Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: blank page when a ref is missing but specified in url #21598

Merged
merged 2 commits into from
Mar 15, 2023

Conversation

ndelangen
Copy link
Member

Closes #21504

What I did

I fixed the error being throw and return undefined instead in the manager-api code when resolving a story that didn't exists in a ref

I fixed an issue where the canvas would remain blank, because there was no active frame

How to test

  1. Run a sandbox or the core ui storybook
  2. Open Storybook in your browser
  3. navigate to http://localhost:6006/?path=/docs/design-system2_avatarlist--docs

@ndelangen ndelangen self-assigned this Mar 14, 2023
@ndelangen ndelangen added the bug label Mar 14, 2023
@ndelangen ndelangen requested a review from tmeasday March 15, 2023 10:27
Copy link
Member

@tmeasday tmeasday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ndelangen ndelangen merged commit 808e26d into next Mar 15, 2023
@ndelangen ndelangen deleted the norbert/fix-blank-page-missing-ref branch March 15, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Composition - blank page when path/storyId contains underscore
2 participants