Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): source preview for angular stories does not show proper props values #21609

Merged
merged 4 commits into from
Mar 17, 2023

Conversation

sheriffMoose
Copy link
Contributor

Closes #21066

What I did

  • enforce using brackets as a best practice for inputs in angular components.
  • fix values showing as false because they don't have enum type.
  • display string props within single quotes pair.
  • display object & array items as JSON strings instead of just a duplicate of propertyName.

Before

image

After

image

How to test

  • CI Passes

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@valentinpalkovic valentinpalkovic added the ci:daily Run the CI jobs that normally run in the daily job. label Mar 16, 2023
@sheriffMoose sheriffMoose merged commit 073eae6 into storybookjs:next Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
angular bug ci:daily Run the CI jobs that normally run in the daily job.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Angular Source Snippets render string args incorrectly
2 participants