Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI: Fix migration summary message #21862

Merged
merged 1 commit into from
Mar 31, 2023
Merged

Conversation

yannbf
Copy link
Member

@yannbf yannbf commented Mar 31, 2023

Closes #

What I did

This PR fixes a scenario overlooked previously, where even if you don't have duplicated dependencies, you would get part of the "duplicated dependencies" message:

image

How to test

  1. See the tests

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@yannbf yannbf merged commit 270a169 into next Mar 31, 2023
@yannbf yannbf deleted the fix/duplicated-dependencies-message branch March 31, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants