Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-enable Vue2 Vite sandbox #21940

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Re-enable Vue2 Vite sandbox #21940

merged 1 commit into from
Apr 5, 2023

Conversation

JReinhold
Copy link
Contributor

What I did

This PR re-enables the Vue2 Vite sandbox. It seems we forgot to do it as a follow-up to #20750, so it's been gray in the status page for a few weeks.

How to test

Checklist

  • Make sure your changes are tested (stories and/or unit, integration, or end-to-end tests)
  • Make sure to add/update documentation regarding your changes
  • If you are deprecating/removing a feature, make sure to update
    MIGRATION.MD

Maintainers

  • If this PR should be tested against many or all sandboxes,
    make sure to add the ci:merged or ci:daily GH label to it.
  • Make sure this PR contains one of the labels below.

["cleanup", "BREAKING CHANGE", "feature request", "bug", "documentation", "maintenance", "dependencies", "other"]

@JReinhold JReinhold self-assigned this Apr 5, 2023
@JReinhold JReinhold requested a review from yannbf April 5, 2023 08:31
@JReinhold JReinhold added the build Internal-facing build tooling & test updates label Apr 5, 2023
@JReinhold JReinhold changed the title Next Re-enable Vue2 Vite sandbox Apr 5, 2023
@JReinhold JReinhold mentioned this pull request Apr 5, 2023
Closed
5 tasks
@JReinhold JReinhold added ci:daily Run the CI jobs that normally run in the daily job. patch:yes Bugfix & documentation PR that need to be picked to main branch labels Apr 5, 2023
@JReinhold JReinhold merged commit 0da3ce3 into next Apr 5, 2023
@JReinhold JReinhold deleted the vue2-vite-sandbox branch April 5, 2023 09:24
@shilman shilman added the patch:done Patch/release PRs already cherry-picked to main/release branch label Apr 6, 2023
shilman pushed a commit that referenced this pull request Apr 6, 2023
@JReinhold @shilman
Merge pull request #21940 from storybookjs/vue2-vite-sandbox
b2fea3e 
Re-enable Vue2 Vite sandbox
@dannyhw dannyhw mentioned this pull request Feb 5, 2024
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yannbf yannbf yannbf approved these changes

Assignees

@JReinhold JReinhold

Labels
build Internal-facing build tooling & test updates ci:daily Run the CI jobs that normally run in the daily job. patch:done Patch/release PRs already cherry-picked to main/release branch patch:yes Bugfix & documentation PR that need to be picked to main branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JReinhold @yannbf @shilman